Hotfix and cleanup ULID optimizations #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martelogan
changed the title
martelogan
commented
Jun 10, 2024
lib/ulid/constants.rb
Outdated
Comment on lines
27
to
28
| B32_CROCKFORD_FRAGMENT = "JKMNPQRSTVWXYZ" | ||
| B32_RCF4648_FRAGMENT = "ijklmnopqrstuv" # downcase becase .to_s(32) is always lowercase |
Member
Author
There was a problem hiding this comment.
Should be handled as frozen by
ulid-ruby/lib/ulid/constants.rb
Line 1 in 7d82497
There was a problem hiding this comment.
yea, I just wanted to make it visually comparable. this is probably better
colinbendell
approved these changes
Jun 10, 2024
JonathanOfTheWell
approved these changes
Jun 10, 2024
martelogan
force-pushed
the
hotfix-ulid-optimizations
branch
from
f02d739 to
de91761
Compare
martelogan
added
the
#gsd:40924
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change in this PR is the fix in 3ba0841 to prevent
b32from beingnilin the absence of changes when modified bytr!andupcase!. This will fix intermittent failures which we sometimes encounter in integrating the forked gem to caller code.While I was at it, I happened to notice that there was also some unresolved PR feedback on abachman#10 so I figured I may as well solve those also - per 7d82497 .